From fd92121b140410a0081413b54d38e63731a7823f Mon Sep 17 00:00:00 2001 From: teidesu Date: Tue, 4 May 2021 14:13:06 +0300 Subject: [PATCH] fix(core): do not rename in case of an error while writing --- packages/core/src/storage/json-file.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/core/src/storage/json-file.ts b/packages/core/src/storage/json-file.ts index 419460b1..06beae20 100644 --- a/packages/core/src/storage/json-file.ts +++ b/packages/core/src/storage/json-file.ts @@ -81,7 +81,8 @@ export class JsonFileStorage extends JsonMemoryStorage { this._safe ? this._filename + '.tmp' : this._filename, this._saveJson(), (err?: Error) => { - if (this._safe) { + if (err) reject(err) + else if (this._safe) { fs.rename( this._filename + '.tmp', this._filename, @@ -90,10 +91,7 @@ export class JsonFileStorage extends JsonMemoryStorage { else resolve() } ) - } else { - if (err) reject(err) - else resolve() - } + } else resolve() } ) })