chore(client): reworked codegen, use prototype methods instead of fields

packages/client/scripts/generate-client.cjs

@@ -258,6 +258,7 @@ async function addSingleMethod(state, fileName) {
 
             const isExported = (stmt.modifiers || []).find((mod) => mod.kind === ts.SyntaxKind.ExportKeyword)
             const isInitialize = checkForFlag(stmt, '@initialize')
+            const isManualImpl = checkForFlag(stmt, '@manual-impl')
             const isInitializeSuper = isInitialize === 'super'
             const aliases = (function () {
                 const flag = checkForFlag(stmt, '@alias')
@@ -303,6 +304,13 @@ async function addSingleMethod(state, fileName) {
                 }
             }
 
+            if (isManualImpl) {
+                state.impls.push({
+                    name: isManualImpl.split('=')[1],
+                    code: stmt.getFullText(),
+                })
+            }
+
             if (!isExported) continue
 
             const firstArg = stmt.parameters[0]
@@ -348,7 +356,7 @@ async function addSingleMethod(state, fileName) {
                         state.imports[module] = new Set()
                     }
 
-                    if (!isManual) state.imports[module].add(name)
+                    state.imports[module].add(name)
                 }
             }
         } else if (stmt.kind === ts.SyntaxKind.InterfaceDeclaration) {
@@ -420,6 +428,7 @@ async function main() {
             used: {},
             list: [],
         },
+        impls: [],
         copy: [],
         files: {},
     }
@@ -432,7 +441,8 @@ async function main() {
 
     output.write(
         '/* eslint-disable @typescript-eslint/no-unsafe-declaration-merging, @typescript-eslint/unified-signatures */\n' +
-            '/* THIS FILE WAS AUTO-GENERATED */\n',
+        '/* eslint-disable @typescript-eslint/no-unsafe-argument */\n' +
+        '/* THIS FILE WAS AUTO-GENERATED */\n',
     )
     Object.entries(state.imports).forEach(([module, items]) => {
         items = [...items]
@@ -480,6 +490,7 @@ on(name: string, handler: (...args: any[]) => void): this\n`)
     const printer = ts.createPrinter()
 
     const classContents = []
+    const classProtoDecls = []
 
     state.methods.list.forEach(
         ({
@@ -628,9 +639,15 @@ on(name: string, handler: (...args: any[]) => void): this\n`)
 
                 if (!overload && !isManual) {
                     if (hasOverloads) {
-                        classContents.push('// @ts-expect-error .bind() kinda breaks typings for overloads')
+                        classProtoDecls.push('// @ts-expect-error this kinda breaks typings for overloads, idc')
                     }
-                    classContents.push(`${name} = ${origName}.bind(null, this)`)
+                    classProtoDecls.push(`TelegramClient.prototype.${name} = function(...args) {`)
+
+                    if (hasOverloads) {
+                        classProtoDecls.push('// @ts-expect-error this kinda breaks typings for overloads, idc')
+                    }
+                    classProtoDecls.push(`    return ${origName}(this, ...args);`)
+                    classProtoDecls.push('}\n')
                 }
             }
         },
@@ -649,7 +666,9 @@ on(name: string, handler: (...args: any[]) => void): this\n`)
     output.write('}\n')
 
     classContents.forEach((line) => output.write(line + '\n'))
-    output.write('}')
+    output.write('}\n')
+    classProtoDecls.forEach((line) => output.write(line + '\n'))
+    state.impls.forEach(({ name, code }) => output.write(`TelegramClient.prototype.${name} = ${code}\n`))
 
     // format the resulting file with prettier
     const targetFile = path.join(__dirname, '../src/client.ts')

packages/client/src/methods/_init.ts

@@ -10,8 +10,6 @@ import { Conversation } from '../types/conversation.js'
 // @copy
 import { _defaultStorageFactory } from '../utils/platform/storage.js'
 // @copy
-import { start } from './auth/start.js'
-// @copy
 import {
     enableUpdatesProcessing,
     makeParsedUpdateHandler,
@@ -73,19 +71,5 @@ function _initializeClient(this: TelegramClient, opts: TelegramClientOptions) {
                 },
             }),
         })
-
-        this.start = async (params) => {
-            const user = await start(this, params)
-            await this.startUpdatesLoop()
-
-            return user
-        }
-    } else {
-        this.start = start.bind(null, this)
-    }
-    this.run = (params, then) => {
-        this.start(params)
-            .then(then)
-            .catch((err) => this._emitError(err))
     }
 }

packages/client/src/methods/auth/run.ts

@@ -13,7 +13,6 @@ import { start } from './start.js'
  *
  * @param params  Parameters to be passed to {@link start}
  * @param then  Function to be called after {@link start} returns
- * @manual
  */
 export function run(
     client: BaseTelegramClient,

packages/client/src/methods/auth/start.ts

@@ -1,6 +1,7 @@
 /* eslint-disable no-console */
 import { BaseTelegramClient, MaybeAsync, MtArgumentError, tl } from '@mtcute/core'
 
+import type { TelegramClient } from '../../client.js'
 import { MaybeDynamic, SentCode, User } from '../../types/index.js'
 import { normalizePhoneNumber, resolveMaybeDynamic } from '../../utils/misc-utils.js'
 import { getMe } from '../users/get-me.js'
@@ -210,3 +211,15 @@ export async function start(
 
     throw new MtArgumentError('Failed to log in with provided credentials')
 }
+
+// @manual-impl=start
+/** @internal */
+async function _start(this: TelegramClient, params: Parameters<typeof start>[1]) {
+    const user = await start(this, params)
+
+    if (!this.network.params.disableUpdates) {
+        await this.startUpdatesLoop()
+    }
+
+    return user
+}